Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )
Change subject: cpu/x86/lapic: Support x86_64 and clean up code ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/36777/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36777/6//COMMIT_MSG@10 PS6, Line 10: didn't
does not
Done
https://review.coreboot.org/c/coreboot/+/36777/6//COMMIT_MSG@12 PS6, Line 12: compiles to
is
Done
https://review.coreboot.org/c/coreboot/+/36777/6//COMMIT_MSG@13 PS6, Line 13: qemu
QEMU
Done
https://review.coreboot.org/c/coreboot/+/36777/6//COMMIT_MSG@17 PS6, Line 17: Qemu
QEMU
Done
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... PS6, Line 3:
#include <stdint. […]
Done
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... PS6, Line 8: unsigned long
why leave this `unsigned long` here?
Done
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... PS6, Line 42: uint32_t
Why 32? if it's not 32 exactly, why not use `unsigned int`?
Done
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... PS6, Line 60: volatile
why volatile?
Done