Vlado Cibic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33328 )
Change subject: mainboard: Add support for ASUS P8Z77-M PRO desktop mainboard ......................................................................
Patch Set 41: Code-Review+1
(3 comments)
Patch Set 40: Code-Review+1
(9 comments)
Looks very nice!
thx for all your help!
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33328/32//COMMIT_MSG@10 PS32, Line 10:
Even MRC with 4 DIMMs is working?
Not sure. I only have 2 DIMMs kits to test. Seem to work ok in both blue and black slots tho.
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... File Documentation/mainboard/asus/p8z77-m_pro.md:
https://review.coreboot.org/#/c/33328/38/Documentation/mainboard/asus/p8z77-... PS38, Line 110: Gb
Gigabit or GigaByte?
Byte
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... File src/mainboard/asus/p8z77-m_pro/devicetree.cb:
https://review.coreboot.org/#/c/33328/38/src/mainboard/asus/p8z77-m_pro/devi... PS38, Line 18: : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4"
not sure if those are needed, the board doesn't seem to use displayport
Let's test it.... Hmmm... not needed, apparently. VGA/DVI-D/HDMI seem to work ok without that.