Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40248 )
Change subject: soc/amd/picasso/i2c: do not init I2C4
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40248/1/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40248/1/src/soc/amd/picasso/i2c.c@2...
PS1, Line 23: * otherwise this slave device will not be able to work.
Thanks. Understood. I would have thought, it would be easier graspable than the comment. […]
If you initialize a slave as if it were a master, it won't really work I guess
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3ddecd293f550a4df5e667094c69f5c115e29c
Gerrit-Change-Number: 40248
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Magf -
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Apr 2020 20:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment