Attention is currently required from: Tim Wawrzynczak, Paul Menzel.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61033 )
Change subject: mb/google/brya/var/vell: update gpio for DMIC
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61033/comment/304a553f_e9a80a1d
PS3, Line 9: Data on channel 0 & 1 are normal (from DMIC) but there are noise on channel 2 & 3, so change to NF
yes, These pins will cause noise when record voice
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b5ccd2c239e526e4f1ce2d5ed6c1386303590c8
Gerrit-Change-Number: 61033
Gerrit-PatchSet: 5
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
coreboot.test@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 14 Feb 2022 07:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment