Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54098 )
Change subject: ec/google/chromeec: OEM variables support for DPTF
......................................................................
Patch Set 3:
(2 comments)
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/54098/comment/f1822c64_5145979e
PS2, Line 314: ODVP
I am a little confused. […]
write_ietm() is to populate those ODVP0-5 from override as mentioned in CL 54279
https://review.coreboot.org/c/coreboot/+/54098/comment/546f1d4d_f22832c9
PS2, Line 315: ODV0
Where are these ODV0-5 defined? Where do these objects exist?
These object there in ec.asl under CL 51937
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79fbf00521d54e66b6cd7d95b026a76fd3a4394b
Gerrit-Change-Number: 54098
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 27 May 2021 18:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment