Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31346 )
Change subject: libpayload/sys/types.h: Add definition for off_t
......................................................................
Patch Set 3:
I don't understand how this information can help during
programming? ;)
Isn't it always helpful to know what size the types you're using are? I mean, sometimes it doesn't matter, but sometimes it does. When I see an ssize_t I know immediately how many bytes it must have on every architecture. When I see a 'long' (or some variation of it), I need to start digging to be sure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c0c1bc1a959db7863cbad2ba29318da162431be
Gerrit-Change-Number: 31346
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Feb 2019 20:17:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment