Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )
Change subject: mainboard/google/puff: Configure HDA registers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... PS1, Line 66: # Intel HDA Curious, I would have expected this "overridetree.cb" to inherit some of these common registers from the hatch baseboard [0]. Perhaps we just need to disabled Ssp1 & Dmic0 here?
If so, can you also modify the comment to describe exactly what we are doing (cf the comment above the equivalent code block @ [0].
[0] https://cs.corp.google.com/chromeos_public/src/third_party/coreboot/src/main...