7 Apr
2021
7 Apr
'21
7:35 p.m.
Attention is currently required from: Kevin Chang, Nick Vaccaro, YH Lin, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52150 )
Change subject: lillupup: provide additional VBT for lillipup OLED sku ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/mainboard/google/volteer/variants/lindar/variant.c:
https://review.coreboot.org/c/coreboot/+/52150/comment/871ff527_a08445f9 PS2, Line 26: case SKU_6_OLED: : case SKU_7_OLED: I think we shouldn't use the SKU information in the coreboot. Instead, we should use the fw_config.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52150
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1
Gerrit-Change-Number: 52150
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com
Gerrit-Attention: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: YH Lin yueherngl@chromium.org
Gerrit-Attention: Zhuohao Lee zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 08 Apr 2021 01:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment