Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41098 )
Change subject: mb/asus/p2b: Add ACPI support for p3b-f ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/susp... File src/mainboard/asus/p2b/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/susp... PS2, Line 7: * ACPI message indicator. Dot at the end not needed?
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/susp... PS2, Line 33: /*SLST = Arg0*/ Add spaces around the comment characters?
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/susp... PS2, Line 63: Return(Package(0x02){0x00, 0x00}) Add a space at least before {?
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/vari... PS2, Line 169: * Prepare To Sleep, Remove , at the end?
https://review.coreboot.org/c/coreboot/+/41098/2/src/mainboard/asus/p2b/vari... PS2, Line 175: SLST = Arg0 No idea if Firefox/Gerrit is broken, but there are no tabs shown here for indentation. The whole file needs to be unified.