Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/Kconfig:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 3: # dummy
Please remove
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 15: select MAINBOARD_USES_FSP2_0
Not sure if this is needed anymore with SKL FSP 1. […]
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 19: Scope (_SB) : { : Device (PWRB)
Maybe replace with "Device (_SB. […]
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 37: Scope (_SB) { : Device (PCI0)
Device (_SB. […]
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 46: #include <soc/intel/skylake/acpi/sleepstates.asl>
I'd rather #include <southbridge/intel/common/acpi/sleepstates. […]
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 135: device pci 19.1 off end # I2C #5 : device pci 19.2 off end # I2C #4
This inversion looks odd, but I didn't open any datasheet
Done