Attention is currently required from: Arthur Heymans, Christian Walter, Jakub Czapiga, Jeff Daly, Johnny Lin, Marek Maślanka, Sean Rhodes, Tim Chu, Vanessa Eusebio.
Hello Arthur Heymans, Christian Walter, Jakub Czapiga, Jeff Daly, Johnny Lin, Sean Rhodes, Tim Chu, Vanessa Eusebio, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80005?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed: Code-Review+1 by Jakub Czapiga, Verified+1 by build bot (Jenkins)
Change subject: soc/intel: Unify the definition of TCO registers ......................................................................
soc/intel: Unify the definition of TCO registers
Move the definition of the TCO registers used in most boards to a separate file and use it consistently. Do not unify TCO for older incompatible platforms.
BUG=b:314260167 TEST=none
Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6 Signed-off-by: Marek Maslanka mmaslanka@google.com --- M src/soc/intel/apollolake/elog.c M src/soc/intel/apollolake/include/soc/smbus.h M src/soc/intel/common/block/smbus/tco.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/pch/include/intelpch/smbus.h A src/soc/intel/common/tco.h M src/soc/intel/denverton_ns/include/soc/pmc.h M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/xeon_sp/include/soc/smbus.h M src/southbridge/intel/common/tco.h M src/southbridge/intel/common/watchdog.c 11 files changed, 64 insertions(+), 79 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80005/9