Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig@272
PS1, Line 272: bool "Build a relocatable ramstage"
Yeah, I would actually go with first option and remove NO_RELOCATABLE_RAMSTAGE. […]
"if PAYLOAD_PAYLOADER" requires building the image with that payload through the makefiles, which may not be desirable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf60b647a8e3f02b3f88589d30eff9c03515b04c
Gerrit-Change-Number: 37573
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Dec 2019 17:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment