Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67380 )
Change subject: mb/prodrive/atlas: Configure Acoustic noise mitigation
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67380/comment/c3a6b103_95a1d80c
PS1, Line 10: - Set slow slew rate VCCIA and VCCGT to 4
How about:
- Set slow slew rate to fast/4 for VCCIA and VCCGT
https://review.coreboot.org/c/coreboot/+/67380/comment/67915bc1_cce238b6
PS1, Line 11: - Set FastPkgCRampDisable VCCIA and VCCGT to 1
How about:
- Disable fast slew rate for deep package C states for VCCIA and VCCGT
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia344d9d939c3323bac82afdf25d5fff81081f9c8
Gerrit-Change-Number: 67380
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 07 Sep 2022 10:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment