21 Jul
2020
21 Jul
'20
8:29 p.m.
Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... PS4, Line 12: #define TOUCH_INT_ODL GPP_D4_IRQ
I don't see it being used anywhere. Can be removed.
Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0
Gerrit-Change-Number: 43153
Gerrit-PatchSet: 5
Gerrit-Owner: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Jul 2020 18:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment