19 Aug
2019
19 Aug
'19
6:36 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34751 )
Change subject: arch/x86: Refactor run_postcar_phase() implementation ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34751/14/src/arch/x86/postcar_loade... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34751/14/src/arch/x86/postcar_loade... PS14, Line 233: struct prog prog why isn't this being passed by reference?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d2200d95e68c0eb01681b8f9b71b3d30d122c43
Gerrit-Change-Number: 34751
Gerrit-PatchSet: 14
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Aug 2019 16:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment