Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33456 )
Change subject: mb/google/hatch/variants/helios: Use LPDDR3 memory
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33456/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/helios/Makefile.inc:
https://review.coreboot.org/#/c/33456/1/src/mainboard/google/hatch/variants/...
PS1, Line 17: LP_16G_2133
Shouldn't this be at index 1?
According to the chart in comment #2 on the bug, 0000 is for the 512Mbit parts, and 0010 is for the 1024Mbit parts. Do we want to have them change the strapping, and then the other vendor's parts (if not covered by these SPDs) can have slots 0010 and 0011?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebaba2ec65dfcf36674b4733b421ada107b22b09
Gerrit-Change-Number: 33456
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 21:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment