build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: /soc/amd/acpi Move ACPI IVRS generation to coreboot ......................................................................
Patch Set 3:
(20 comments)
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 398: cap_offset_10 = pci_read_config32(iommu_dev, ivrs->ivhd.capability_offset + 0x10); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 414: ivrs->ivhd.iommu_info = pci_read_config16(iommu_dev, \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 416: ivrs->ivhd.iommu_info |= (pci_read_config16(iommu_dev, \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 417: ivrs->ivhd.capability_offset + 0xC) & 0x1F) << IOMMU_INFO_UNIT_ID_SHIFT; line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 419: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_HATS) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 421: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GATS) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 423: ivrs->ivhd.iommu_feature_info |= ((cap_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR) \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 423: ivrs->ivhd.iommu_feature_info |= ((cap_offset_10 & CAP_OFFSET_0X10_MSI_NUM_PPR) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 425: >> IOMMU_FEATURE_MSI_NUM_PPR_SHIFT:0) ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 426: ivrs->ivhd.iommu_feature_info |= (mmio_x4000_value & \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 428: ivrs->ivhd.iommu_feature_info |= (mmio_x4000_value & MMIO_0X4000_N_COUNTER) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 430: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_PAS_MAX) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 432: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_HE_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 434: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GA_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 436: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_IA_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 438: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GLX_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 440: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_GT_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 442: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_NX_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 444: ivrs->ivhd.iommu_feature_info |= ((mmio_x30_value & MMIO_0X30_XT_SUP) \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/43804/3/src/soc/amd/picasso/agesa_a... PS3, Line 448: ivrs->iv_info = pci_read_config32(iommu_dev, \ Avoid unnecessary line continuations