Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45598 )
Change subject: mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@7
PS4, Line 7: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram
mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram
Done
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@9
PS4, Line 9: needs
: to be overridde.
needs to be overridden
Done
https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee...
PS4, Line 51: usb2
suggestion: These settings improve the USB2 Port1 eye diagram
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If076c644783fa2992ac062d6469f9c49e6d5ff24
Gerrit-Change-Number: 45598
Gerrit-PatchSet: 6
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Sep 2020 01:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment