Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47808 )
Change subject: sb/intel/lynxpoint: Replace hard-coded IDs with defines ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47808/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47808/5//COMMIT_MSG@15 PS5, Line 15: Built with BUILD_TIMELESS=1 and generated coreboot.rom stays the same. Which board, though? I usually write the following:
Tested with BUILD_TIMELESS, $VENDOR $BOARD remains identical.
https://review.coreboot.org/c/coreboot/+/47808/5/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/azalia.c:
https://review.coreboot.org/c/coreboot/+/47808/5/src/southbridge/intel/lynxp... PS5, Line 136: /* 0x8c20 */ If you're going to keep the values as comments, why use the defines in the first place?