[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel SkyLake Scalable Processor support

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel SkyLake Scalable Processor support
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38548/16/src/soc/intel/skylake_sp/a... 
File src/soc/intel/skylake_sp/acpi.c:

https://review.coreboot.org/c/coreboot/+/38548/16/src/soc/intel/skylake_sp/a... 
PS16, Line 17: #include <assert.h>
             : #include <arch/acpi.h>
             : #include <arch/cpu.h>
             : #include <arch/acpigen.h>
             : #include <arch/ioapic.h>
             : #include <arch/smp/mpspec.h>
             : #include <string.h>
             : #include <cpu/intel/turbo.h>
             : #include <cpu/x86/smm.h>
             : #include <intelblocks/acpi.h>
             : #include <intelblocks/msr.h>
             : #include <intelblocks/pmclib.h>
             : #include <device/pci.h>
             : #include <cbmem.h>
             : #include <soc/acpi.h>
             : #include <soc/cpu.h>
             : #include <soc/soc_util.h>
             : #include <soc/pm.h>
             : #include <soc/pmc.h>
             : #include <soc/pci_devs.h>
             : #include <soc/hob_iiouds.h>
             : #include <soc/hob_memmap.h>
             : #include "chip.h"
are you sure that you use all of those includes?

please include only what you use

(please also check the other files)