Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47719 )
Change subject: mb/google/zork: Remove 50ms WIFI delay ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47719/1/src/mainboard/google/zork/v... PS1, Line 213: mdelay(50);
in order to guarantee the mdelay, do we need to set a timer and inject a delay later? I would guess […]
Not a bad idea, however I don't think we're anywhere near the edge now. In an actual implementation, it would need some care for doing it properly. romstage and ramstage don't share data, i.e. you can't just add a static variable in this file to store a TSC value to be checked later.