Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87094?usp=email )
Change subject: mb/google/bluey: Set correct Kconfig defaults for peripherals ......................................................................
mb/google/bluey: Set correct Kconfig defaults for peripherals
Update the default Kconfig values for the google/bluey mainboard to specify the correct hardware instances/buses used for various peripherals as per bluey schematics (dated 04/15).
Changes: - TPM I2C bus set to 0x10. - ChromeEC SPI bus set to 0xb.
Removes previous TODO placeholders.
BUG=b:404985109 TEST=Successfully built google/bluey with the Qualcomm x1p42100 SoC.
Change-Id: I48283e9f5b9dc1d2f203dadbdf6d4e27566f0a83 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/87094 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/google/bluey/Kconfig M src/mainboard/google/bluey/board.h 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved
diff --git a/src/mainboard/google/bluey/Kconfig b/src/mainboard/google/bluey/Kconfig index a22cae6..0746970 100644 --- a/src/mainboard/google/bluey/Kconfig +++ b/src/mainboard/google/bluey/Kconfig @@ -49,13 +49,13 @@ config DRIVER_TPM_I2C_BUS depends on I2C_TPM hex - default 0x00 # TODO + default 0x10
config DRIVER_TPM_I2C_ADDR default 0x50
config EC_GOOGLE_CHROMEEC_SPI_BUS hex - default 0x0 # TODO + default 0xb
endif # BOARD_GOOGLE_BLUEY_COMMON diff --git a/src/mainboard/google/bluey/board.h b/src/mainboard/google/bluey/board.h index e6de22e..f7c4f23 100644 --- a/src/mainboard/google/bluey/board.h +++ b/src/mainboard/google/bluey/board.h @@ -6,8 +6,8 @@ #include <assert.h> #include <gpio.h>
-#define GPIO_AP_EC_INT GPIO(0) -#define GPIO_GSC_AP_INT GPIO(0) +#define GPIO_AP_EC_INT GPIO(67) +#define GPIO_GSC_AP_INT GPIO(34)
void setup_chromeos_gpios(void);