16 Jul
2021
16 Jul
'21
12:37 a.m.
Attention is currently required from: Raul Rangel, Eric Peers, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56229 )
Change subject: lib/thread: Add thread_handle ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/include/thread.h:
https://review.coreboot.org/c/coreboot/+/56229/comment/d9e7c639_e3e07333 PS5, Line 111: return CB_ERR;
I moved it out of the #if guards. This will result in a linker error. […]
Sounds good! In fact, would probably be good to do that for thread_run() and variations too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f64d0c5a5acad4431a605f0b0b5100dc5358ff
Gerrit-Change-Number: 56229
Gerrit-PatchSet: 6
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Eric Peers epeers@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Jul 2021 22:37:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment