Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32870 )
Change subject: fit: Refactor config node handling
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32870/5/src/lib/fit_payload.c
File src/lib/fit_payload.c:
https://review.coreboot.org/#/c/32870/5/src/lib/fit_payload.c@198
PS5, Line 198: #if defined(CONFIG_LINUX_COMMAND_LINE)
: fit_update_chosen(dt, (char *)CONFIG_LINUX_COMMAND_LINE);
: #endif
No, because this is a string Kconfig, CONFIG() is only for boolean Kconfigs.
not blocking +2, but will it help if we for example define the config as NULL and check that?
simply trying to eliminate conditional compile.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia79e0fd0e1159c4aca64c453b82a0379b133350d
Gerrit-Change-Number: 32870
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 00:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment