Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40796 )
Change subject: mainboard/google/kahlee: move specific setting to variant ......................................................................
Patch Set 2: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/40796/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40796/2//COMMIT_MSG@10 PS2, Line 10: Maybe mention that this file is currently only used for careena, so after moving everything to the careena directory, the rest can be removed?
https://review.coreboot.org/c/coreboot/+/40796/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/careena/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40796/2/src/mainboard/google/kahlee... PS2, Line 17: + Remove this?