Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8
......................................................................
Patch Set 16:
Patch Set 16:
This board does not use appropriate FSP binary by default. Default configuration will point to CometLake1 FSP instead of CometLakeS FSP (submodule probably needs update). Another thing to do would be to point set correct FSP_FD_PATH and FSP_HEADER_PATH for this board. Also the microcode is not yet available in the intel-microcode repository, so building a working image is quite troublesome.
Patch set that implements the FSP selection: https://review.coreboot.org/c/coreboot/+/44954
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf723ada53dc441cb9fabc8efb1dcd3da8e0991c
Gerrit-Change-Number: 36685
Gerrit-PatchSet: 16
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Sep 2020 06:37:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment