30 May
2019
30 May
'19
4:34 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33112 )
Change subject: Kconfig: Make ramstage kconfigs dependent on CONFIG_ARCH_RAMSTAGE_X86_32/64 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33112/1//COMMIT_MSG@11 PS1, Line 11: is not selected.
Why? What is the reasoning?
In case we would like to deselect CONFIG_ARCH_RAMSTAGE_X86_32 config then ramstage won't be there but still COMPRESS_RAMSTAGE and RELOCATABLE_RAMSTAGE configs will be default enable.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d0c31152ffa8faf62b10a6bda12c9ad2e786d94
Gerrit-Change-Number: 33112
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Thu, 30 May 2019 14:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment