Attention is currently required from: Martin Roth, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52322 )
Change subject: Added LOCKDIS option to show SPI as writable ......................................................................
Patch Set 1:
(71 comments)
File src/ec/starlabs/it8987/acpi/cmos.asl:
https://review.coreboot.org/c/coreboot/+/52322/comment/9447c632_c98961b5 PS1, Line 6: NVRI, 8, trailing whitespace
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52322/comment/acb4d9b1_a7cc5b5f PS1, Line 33: // Our embedded controller device. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/6c27a516_d57418b8 PS1, Line 46: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/8ff5ac3b_a7d17a92 PS1, Line 49: Name(PVOL, ASL_PVOL_DEFOF_NUM) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/0f202292_f9f889df PS1, Line 52: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ec1b06ce_c89f3aae PS1, Line 82: Name(BTEN, 0) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/2b74f2a1_a3171c23 PS1, Line 111: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/4d80275b_69a69efb PS1, Line 113: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/33029811_c6b7d86b PS1, Line 120: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/1c69e64c_eff46098 PS1, Line 123: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/7aefd02d_1e9ac27b PS1, Line 134: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/eebd8601_a488438d PS1, Line 157: Offset(0x06), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/beea3bd0_5a72bbfd PS1, Line 158: SKID, 8, // SKU ID trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/9a8b62c5_007a2be9 PS1, Line 162: ECOS, 8, // Enter OS flag trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/3d99dda0_9a88556f PS1, Line 164: ECHK, 8, // Hot keys flag trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/f6e734aa_f544d34c PS1, Line 169: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/c73da56c_fbd1f440 PS1, Line 174: Offset(0x1E), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/38178327_6b942984 PS1, Line 175: BTHP, 8, // Health Battery Percentage trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/c02e1263_421e7a14 PS1, Line 181: Offset(0x2C), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/123510d4_eea095b5 PS1, Line 182: FNST, 8, // FN LOCK key status. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/b3f37d69_1624f1f4 PS1, Line 184: Offset(0x3F), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/409fabd3_61fa8981 PS1, Line 185: SFAN, 8, // Set Fan Speed. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/5f3e4bf4_e743701e PS1, Line 186: BTMP, 16, // Battery Temperature. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/dbece1ce_86b3bd34 PS1, Line 187: BCNT, 16, // Battery Cycle Count. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/0cd4724d_4fb8f0cf PS1, Line 188: FRMP, 16, // Fan Current Speed. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/95ba48a9_81272f78 PS1, Line 189: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/3befff89_c293f2ec PS1, Line 217: CPTM, 8, // CPU Temperature trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/5122488c_bdd37783 PS1, Line 219: Offset(0x72), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/817a97ee_f72ebc01 PS1, Line 220: TER2, 8, // Charger Temperature, Charger thermistor support trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ce770f43_e6986869 PS1, Line 226: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/49658089_a7138e78 PS1, Line 236: B1CR, 16, // Battery#1 Present Rate trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/49ea3ab0_c31eba98 PS1, Line 240: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/9c02c1c8_7bec57b1 PS1, Line 255: MGIC, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/6d304acc_6bc86c34 PS1, Line 261: MGO0, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ddc6e002_59c84833 PS1, Line 276: MGOF, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/dac467cf_5534698c PS1, Line 284: // PPM->OPM CCI indicator trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/b2e18ad4_c87fe27d PS1, Line 299: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/85bbb703_a0344f37 PS1, Line 305: , 1, // BIT7 Reserved trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/49292188_266ccdd6 PS1, Line 353: Method(_Q40) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/8fa78011_ae7387aa PS1, Line 357: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/2935a5e1_09f557ca PS1, Line 358: Method(_Q41) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/f6766ed8_60fd10d3 PS1, Line 362: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/aac8cb38_75d07539 PS1, Line 363: Method(_Q42) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/aac365f8_e4a0c438 PS1, Line 367: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/9e63e7d4_5145ce77 PS1, Line 368: Method(_Q43) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/c146ebbb_8ca5e2f4 PS1, Line 373: Method(_Q44) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/5ba77691_2a7d36fe PS1, Line 376: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/03af460c_f8620dee PS1, Line 378: Method(_Q45) trailing whitespace
File src/ec/starlabs/it8987/acpi/hid.asl:
https://review.coreboot.org/c/coreboot/+/52322/comment/3cb01b8f_770043f7 PS1, Line 32: 0x11111111, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ed4410c1_864f1ead PS1, Line 33: 0x22222222, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ec14eaba_bb0569cd PS1, Line 34: 0x33333333, trailing whitespace
File src/ec/starlabs/it8987/acpi/keyboard.asl:
https://review.coreboot.org/c/coreboot/+/52322/comment/6f9434d1_6405bf5e PS1, Line 10: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/36ff8695_f6d9e3da PS1, Line 17: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/e144cae0_c7f77b03 PS1, Line 18: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/c0eeda93_b3aa632d PS1, Line 22: _SB.HIDD.HPEM(8) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/99e540a5_4ddf3ac7 PS1, Line 25: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/eec7256f_4263940d PS1, Line 29: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/ef031c42_e71d9e4f PS1, Line 30: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/8c4263d5_ffc38d0e PS1, Line 34: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/490b09e0_65a626bc PS1, Line 50: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/e5801ef4_df9fd44c PS1, Line 57: trailing whitespace
File src/ec/starlabs/it8987/acpi/lid.asl:
https://review.coreboot.org/c/coreboot/+/52322/comment/97bcf3ce_d9635ff6 PS1, Line 35: DEBUG = "---> IT8987 LID: Q0C (close event)" trailing whitespace
File src/ec/starlabs/it8987/ec.c:
https://review.coreboot.org/c/coreboot/+/52322/comment/7c3380bf_e288f0dd PS1, Line 14: void it8987_write_data(u8 addr, u8 data) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/52322/comment/ed4f2bd9_e70fb9ce PS1, Line 19: u8 it8987_read_data(u8 addr) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/52322/comment/b203df0b_3696fd61 PS1, Line 21: return(inb(IT8987E_DATA)); return is not a function, parentheses are not required
https://review.coreboot.org/c/coreboot/+/52322/comment/fc94dead_4c51c043 PS1, Line 24: u16 it8987_read_chipid(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/52322/comment/0b577fd4_7d107563 PS1, Line 28: u16 it8987_get_version(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/52322/comment/32921100_2b325ece PS1, Line 32: static void it8987_init(struct device *dev) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/52322/comment/634325f7_ea8c0ae1 PS1, Line 55: /* trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/03782dfc_07748d8e PS1, Line 62: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52322/comment/159c584c_781f7595 PS1, Line 65: * corresponding location within the EC RAM. trailing whitespace