Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )
Change subject: amd/picasso/verstage: replace rsa accel with modexp
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver...
PS4, Line 132: sig_swapped[i] = swab32(inout_32[key->arrsize - i - 1]);
What do you mean by "it shall be interpreted as an array of dwords"? It's just big number, not any k […]
This isn't a hardware buffer. It's just a memory buffer.
It would definitely be better if we didn't have to swap the endianness back and forth. Hopefully we can fix that in a future update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I085f043bf2014615d2c9db6df0b7947ee84b9546
Gerrit-Change-Number: 45987
Gerrit-PatchSet: 5
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Oct 2020 16:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment