Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Kapil Porwal, Martin L Roth, Marvin Evers, Michael Strosche, Subrata Banik, Tarun, Tarun Tuli.
Elyes Haouas has posted comments on this change by Michael Strosche. ( https://review.coreboot.org/c/coreboot/+/77374?usp=email )
Change subject: soc/intel/meteorlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 8: Code-Review+1
(6 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/77374/comment/89861d50_a1697958?usp... :
PS8, Line 212: 1:Enable, 0:Disable
update the comment
https://review.coreboot.org/c/coreboot/+/77374/comment/8683b413_c9cdb288?usp... :
PS8, Line 235: * Default 0. Setting this to 1 disables
update
https://review.coreboot.org/c/coreboot/+/77374/comment/5c976987_7e2a3400?usp... :
PS8, Line 301: 1b:Enabled, 0b:Disabled
update
https://review.coreboot.org/c/coreboot/+/77374/comment/1c28b499_d4c2bc98?usp... :
PS8, Line 451: Default 0. Setting this to 1 disables th
update
https://review.coreboot.org/c/coreboot/+/77374/comment/cede8b49_61be5871?usp... :
PS8, Line 456: Enable(1)/Disable(0)
update
https://review.coreboot.org/c/coreboot/+/77374/comment/175fffad_6b292d8c?usp... :
PS8, Line 457: Default 0. Setting this to 1
update
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77374?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15dfd5ed0541352930c3b70252b3e536ad1e6efd
Gerrit-Change-Number: 77374
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Strosche
michael.strosche@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Marvin Evers
marvin.n.evers@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Marvin Evers
marvin.n.evers@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Michael Strosche
michael.strosche@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 19 Jul 2024 19:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes