build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44706 )
Change subject: soc/mediatek/mt8192: Do dramc before calibration pre-settings ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44706/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44706/1/src/soc/mediatek/mt8192/dra... PS1, Line 117: switch(mr_wl) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44706/1/src/soc/mediatek/mt8192/dra... PS1, Line 307: u8 dis_imp_hw = (freq_group > DDRFREQ_1200) ? 0: 1; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44706/1/src/soc/mediatek/mt8192/dra... PS1, Line 336: SHU_MISC_IMPCAL1_IMPCALCNT, (dis_imp_hw? 0x0:0x40)); spaces required around that '?' (ctx:VxW)