Attention is currently required from: Tarun Tuli, Frank Chu.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71650 )
Change subject: mb/google/brya/var/marasov: Disable FPMCU interface
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/marasov/gpio.c:
https://review.coreboot.org/c/coreboot/+/71650/comment/6a54e73f_47d0fabb
PS7, Line 104: GPP_F11
Should it be PAD_NC_LOCK? Same as GPP_F12, GPP_F13, GPP_F15, GPP_F16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304862f0dd201da100b89c79a473eb116fc8263e
Gerrit-Change-Number: 71650
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 09:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment