Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47982 )
Change subject: soc/amd: move bootblock inside main SoC directories ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
I'm ok with this if it's what you want, but having the bootblock directory is pretty standard. While it might not be required, having the bootblock directory is pretty expected. Is there actually a reason to get rid of the bootblock directory?
I find that having a separate directory for only one file just adds clutter and no value and for example all chipsets in northbridge/intel have their bootblock directly in the main directory.
Also the other stages don't have separate directories, so this is a bit more consistent