Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series
......................................................................
Patch Set 28:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@11
PS27, Line 11: see CR 35427
What is needed?
Done
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@9
PS27, Line 9: Most of the X11 boards with socket LGA1151 are basically the same
: boards with just some minor differences.
: To be able to add more x11 boards easily like x11ssm (see CR 35427)
: this restructures the x11ssh tree.
huh? This is one sentence, newline because of line limit
Done
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@13
PS27, Line 13:
Please elaborate a little bit. You rename the directory. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 28
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Sep 2019 11:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment