Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Meera Ravindranath, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48345 )
Change subject: mb/intel/adlrvp: Drop INTEL_CAR_NEM Kconfig select on ADL-P RVP
......................................................................
Patch Set 21:
(1 comment)
File src/mainboard/intel/adlrvp/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/48345/comment/af72dcd6_9f09bfb8
PS21, Line 20: select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
:
: config BOARD_INTEL_ADLRVP_M_EXT_EC
: bool "Alderlake-M RVP with Chrome EC"
: select INTEL_LPSS_UART_FOR_CONSOLE
: select DRIVERS_INTEL_MIPI_CAMERA
: select SOC_INTEL_COMMON_BLOCK_IPU
: select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED
These shouldn't be encessary, the BOARD_SPECIFIC_OPTIONS are covered by all 4 BOARD_INTEL_ADLRVP_* types ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08561c8f50bbc4afe2bcdff4cc50e74d8fa2f68e
Gerrit-Change-Number: 48345
Gerrit-PatchSet: 21
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 18:01:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment