Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51658 )
Change subject: soc/intel/alderlake: Add enum for HDA audio configuration
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51658/comment/cca527f5_00801844
PS2, Line 10: configuration and rename a variable for better readability.
Can you please mention that these UPDs are used for configuring audio over HDMI/DP?
Done
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/51658/comment/873a854f_6c7ec335
PS2, Line 132: uint8_t
bool
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2834d6f4ce1651a609c5563af375f6e365d931fa
Gerrit-Change-Number: 51658
Gerrit-PatchSet: 3
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 21 Apr 2021 13:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment