Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39146 )
Change subject: src/ec,mainboard: Move weak smbios_system_sku() override inwards
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39146/7/src/ec/google/chromeec/ec_s...
File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39146/7/src/ec/google/chromeec/ec_s...
PS7, Line 41: return google_chromeec_smbios_system_sku();
please, no spaces at the start of a line
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05ebfc8126c0fb176ca52c307c658f50611ab6ab
Gerrit-Change-Number: 39146
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 02:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment