Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34400 )
Change subject: mb/google/hatch/var/kindred: Implement variant_devtree_update()
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/...
PS2, Line 33: google_chromeec_cbi_get_sku_id
There is an implementation of get_board_sku() in hatch/mainboard.c. You can make it non-static and use that over here. Then you won't need to call into ec code directly.
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/...
PS2, Line 34: (sku_id == 1)
Isn't this more than just sku 1?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ccb4dae54f223881e0ced9e034bf45b994cc6f2
Gerrit-Change-Number: 34400
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment