Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: src/arch/x86: Use core apic id to get cpu_index()
......................................................................
Patch Set 16: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/26346/16/src/arch/x86/cpu.c
File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/26346/16/src/arch/x86/cpu.c@344
PS16, Line 344: */
I don't understand this comment. It seems to just rephrase what the
code does. But doesn't tell *why* the code does it this way.
What is `cpu_mp structure`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350
Gerrit-Change-Number: 26346
Gerrit-PatchSet: 16
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sat, 11 May 2019 12:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment