12 Jul
2018
12 Jul
'18
1:31 a.m.
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27433 )
Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... PS2, Line 181: PAD_CFG_NC(GPP_D8),
There's a a fix going into EVT2 firmware that is needed for EVT2 to fix a hang bug, but that same fi […]
Okay, let's go with 1) then, which is this CL.
--
To view, visit https://review.coreboot.org/27433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e
Gerrit-Change-Number: 27433
Gerrit-PatchSet: 2
Gerrit-Owner: Ricky Liang jcliang@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Ricky Liang jcliang@chromium.org
Gerrit-Reviewer: Tomasz Figa tfiga@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Jul 2018 04:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes