Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40437 )
Change subject: intel/stm: Place resource list right below MSEG ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40437/1/src/cpu/x86/smm/smm_module_... File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/40437/1/src/cpu/x86/smm/smm_module_... PS1, Line 361: base -= CONFIG_MSEG_SIZE + CONFIG_BIOS_RESOURCE_LIST_SIZE;
Without background, the removal of the else branch is not obvious.
The following was added to the commit:
As part of the change in the BIOS resource list address calculation, the `size` variable was factored out of the conditional in line 361, thus eliminating the else.