Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29013 )
Change subject: amd/stoneyridge: Rearrange southbridge.h ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG@6 PS1, Line 6: : amd/stoneyridge soc/amd/stoneyridge/include/soc:
https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 166: #define DEBUG_PORT_MASK (BIT(16) | BIT(17) | (BIT(18))
Macros with complex values should be enclosed in parentheses
I have seen this kind of problem before. It's encased in parenthesis, but Jenkins believe it's not.