Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42410 )
Change subject: nb/intel/sandybridge/gma.c: Remove useless if condition ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42410/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/42410/1/src/northbridge/intel/sandy... PS1, Line 510: gtt_write(0xa188, 0x1fffe);
this should be ANDing the register with 0x0001ffff instead […]
not sure why there should be a separate write? there are no polls between them. can't we just do something like this?
reg32 = gtt_read(0xa188); reg32 &= 0x1ffff; reg32 &= ~1; gtt_write(0xa188, reg32);