[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/systemagent: Make common northbridge.asl

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )

Change subject: soc/intel/common/systemagent: Make common northbridge.asl
......................................................................

Patch Set 9:

(4 comments)

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
PS8, Line 284: _BAS
> Both _BAS and _LEN get updated now, so this comment should be updated. […]

Ack

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/systemagent/Kconfig:

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
PS8, Line 12: 	default 14
> I understand that, as most platforms use the same value, one would want to make it the default setti […]

Ack

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
PS8, Line 14: reserve
> reserve*d*

Ack

https://review.coreboot.org/c/coreboot/+/38456/8/src/soc/intel/common/block/... 
PS8, Line 32: reserve
> reserve*d*

Ack