Jeff Chase has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36792 )
Change subject: google/endeavour: update GPIOs from schematic ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36792/1/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/gpio.c:
https://review.coreboot.org/c/coreboot/+/36792/1/src/mainboard/google/fizz/v... PS1, Line 151: NONE), /* TPU_RST_PIN40 */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36792/1/src/mainboard/google/fizz/v... PS1, Line 151: NONE), /* TPU_RST_PIN40 */
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/36792/1/src/mainboard/google/fizz/v... PS1, Line 156: NONE), /* TPU_RST_PIN42 */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36792/1/src/mainboard/google/fizz/v... PS1, Line 156: NONE), /* TPU_RST_PIN42 */
please, no spaces at the start of a line
Done