[coreboot-gerrit] Change in coreboot[master]: {src}: Assign values before if statement

[Julius Werner (Code Review)]

Attention is currently required from: Frans Hendriks, Kyösti Mälkki, Alexander Couzens, Aaron Durbin, Patrick Rudolph.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50040 )

Change subject: {src}: Assign values before if statement
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> I was not aware of history of checkpatch. […]

I mean, are you implying that the current style was inconsistent? I would say this is currently allowed and code authors can write code that way at their discretion, what's not consistent about that? There's no single situation where you'd _have_ to write something like this, just like you don't _have_ to use long strings or lines that require breaking or any of the dozen other things we have code style rules for.

Like I mentioned there is also a while() version of this which is used more often, and I think disallowing one while allowing the other would be the bigger inconsistency.