Attention is currently required from: Frans Hendriks, Kyösti Mälkki, Alexander Couzens, Aaron Durbin, Patrick Rudolph.
View Change
1 comment:
Patchset:
Patch Set #3:
I was not aware of history of checkpatch. […]
I mean, are you implying that the current style was inconsistent? I would say this is currently allowed and code authors can write code that way at their discretion, what's not consistent about that? There's no single situation where you'd _have_ to write something like this, just like you don't _have_ to use long strings or lines that require breaking or any of the dozen other things we have code style rules for.
Like I mentioned there is also a while() version of this which is used more often, and I think disallowing one while allowing the other would be the bigger inconsistency.
To view, visit change 50040. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd346d31f1da71271ad1545e5645e57530c7b374
Gerrit-Change-Number: 50040
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Attention: Aaron Durbin <adurbin@chromium.org>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Thu, 04 Feb 2021 23:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment