Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes ......................................................................
drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes
Remove #include "chip.h", which is not needed and causes a build problem in a later change. Alphabetise the #includes. Add <types.h>.
Change-Id: If19ccd144bd352a196adccd75f9f6f139eae4e4a Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45968 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/ipmi/ocp/ipmi_ocp.c 1 file changed, 5 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c index f96ce24..07628ee 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp.c +++ b/src/drivers/ipmi/ocp/ipmi_ocp.c @@ -7,14 +7,15 @@ * end */
+#include <arch/cpu.h> #include <console/console.h> #include <device/device.h> #include <device/pnp.h> -#include <string.h> +#include <drivers/ipmi/ipmi_kcs.h> #include <intelblocks/cpulib.h> -#include <arch/cpu.h> -#include "chip.h" -#include "drivers/ipmi/ipmi_kcs.h" +#include <string.h> +#include <types.h> + #include "ipmi_ocp.h"
static int ipmi_set_processor_information_param1(struct device *dev)