Attention is currently required from: Peter Lemenkov, Angel Pons, Alexander Couzens, Patrick Rudolph, Iru Cai (vimacs). amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541 ......................................................................
Patch Set 21:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52659/comment/029bcc42_ce3097ce PS20, Line 25: (Thunderbolt untested)
Could we have a separate section for untested functionality?
Done
Patchset:
PS20:
Speaking about backlignt. Could +51412 be related? […]
Hmm... I'll try this out.
File src/mainboard/lenovo/w541/Kconfig:
https://review.coreboot.org/c/coreboot/+/52659/comment/cf4e65c8_a28710ab PS20, Line 17: select INTEL_INT15
Can be removed since mainboard.c is gone.
Done
https://review.coreboot.org/c/coreboot/+/52659/comment/9d8c8518_6f084f92 PS20, Line 18: select MAINBOARD_HAS_LIBGFXINIT # FIXME: not working
Remove comment. […]
Done
https://review.coreboot.org/c/coreboot/+/52659/comment/493d4aee_de89b313 PS20, Line 24: select H8_HAS_BAT_TRESHOLDS_IMPL
nit: sort selects alphabetically?
Done
https://review.coreboot.org/c/coreboot/+/52659/comment/b2d7300e_4ca75e28 PS20, Line 37: config USBDEBUG_HCD_INDEX # FIXME: check this : int : default 2
If untested, I'd remove this.
Done
File src/mainboard/lenovo/w541/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/52659/comment/20df83ce_a5122e81 PS20, Line 11: shutdown
nit: `shut down`
Done