Attention is currently required from: Furquan Shaikh, Ren Kuo, Shou-Chieh Hsu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56685 )
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56685/comment/ea15dcec_513aa078 PS7, Line 2: field CAMERA_WFC 38 43 : option CAMERA_NONE 0 : option CAMERA_OVTI5675 33 : option CAMERA_OVTI8856 34 : end : field TS_SOURCE 44 47 : option TS_UNPROVISIONED 0 : option TS_ELAN_6915 1 : option TS_ELAN_6918 2 : option TS_ELAN_0001 3 : option TS_RAYD_0001 4 : option TS_WDHT0002 5 : option TS_GTCH7503 6 : end This is incorrect after evaluating the SSFC. It should be
``` fw_config field CAMERA_WFC 38 40 option CAMERA_WFC_NONE 0 option CAMERA_WFC_OVTI5675 33 option CAMERA_WFC_OVTI8856 34 end field CAMERA_UFC 41 42 option CAMERA_UFC_NONE 0 end field CAMERA_VCM 43 44 option CAMERA_VCM_NONE 0 option CAMERA_VCM0 1 end field TS_SOURCE 45 48 option TS_UNPROVISIONED 0 option TS_ELAN_6915 1 option TS_ELAN_6918 2 option TS_ELAN_0001 3 option TS_RAYD_0001 4 option TS_WDHT0002 5 option TS_GTCH7503 6 end end ```
If none of the projects that are using ELAN6918 has hit the PVT, I would recommend fixing it now.